Search stopped returning accurate results suddenly

View previous topic View next topic Go down

Search stopped returning accurate results suddenly

Post  jbellanca on Tue Jan 28, 2014 11:31 pm

Been using ComicTagger 1.19beta on the Mac (OS X 10.9.1) for a year or so now.  It's always worked great... a few minor bugs, like when it doesn't revert the mouse pointer back from the B&W pinwheel, but minor stuff.  Until, this week.  Now, whenever I search for a comic series, either using Search Online, Auto-Identify, or Auto-Tag, exactly like I always have, it searches for minutes at a time, and returns thousands of results... it looks like a list of every comic series ever.  You can manually scroll through the list and pick what you're looking for, but for some reason, the search functionality is totally broken all of a sudden.  I haven't done any updates or re-installs lately.  (Auto-Tag also only sometimes works now because of this.)  I've tried clearing the cache just in case, but it hasn't helped.  Try, for example, "The Dark Knight Returns" or "Legends of the Dark Knight". Is there any way I can post up some logs or something to help diagnose what's going wrong?

jbellanca

Posts : 1
Join date : 2014-01-28

View user profile

Back to top Go down

Re: Search stopped returning accurate results suddenly

Post  anomander on Wed Jan 29, 2014 1:54 am

It looks like the API has changed from AND to OR. So the longer the title you search for the more results you will get and its unlikely to ever get an exact match in the way it used to.

This needs a comictagger update to accommodate API changes but I have not seen the dev here since Aug 19, 2013 and the last code commit was one day before that.

To be fair in this period comictagger "just worked" so hopefull he will come back now it doesnt Smile

Update: Doesn't work was a bit harsh. In theory it should still work fine but its less than ideal when hundreds of results are presented and you have to manually eyeball the right one.
avatar
anomander

Posts : 74
Join date : 2013-03-28

View user profile

Back to top Go down

Re: Search stopped returning accurate results suddenly

Post  DP812 on Thu Jan 30, 2014 3:27 am

Also having this same problem. I hope CT hasn't given up on this. I posted another problem I was having recently with autotagging a book and never got a response.

DP812

Posts : 74
Join date : 2012-12-08

View user profile

Back to top Go down

Re: Search stopped returning accurate results suddenly

Post  sashalav on Thu Jan 30, 2014 9:21 pm

I thought I had an account on this forum already. Anyway, it seems API did change and it is not clear if this is permanent. To fix it just edit one line. I will post this in google code "issues" too.

Code:

--- comictaggerlib/comicvinetalker.py~  2014-01-30 22:13:34.000000000 -0400
+++ comictaggerlib/comicvinetalker.py   2014-01-30 22:15:31.000000000 -0400
@@ -146,7 +146,7 @@
 
               original_series_name = series_name
 
-               series_name = urllib.quote_plus(series_name.encode("utf-8"))
+               series_name = urllib.quote_plus(series_name.replace(" "," AND ").encode("utf-8"))
                #series_name = urllib.quote_plus(unicode(series_name))
                search_url = self.api_base_url + "/search/?api_key=" + self.api_key + "&format=json&resources=volume&query=" + series_name + "&field_list=name,id,start_year,publisher,image,description,count_of_issues"
                content = self.getUrlContent(search_url + "&page=1")

sashalav

Posts : 1
Join date : 2014-01-30

View user profile

Back to top Go down

Re: Search stopped returning accurate results suddenly

Post  ComicTagger on Fri Jan 31, 2014 1:09 am

I just pushed out a new release to deal with this.

sashalav, thanks for the suggestion, way better than my actual implementation! My python skills are rusty :-) But what's done is done.



avatar
ComicTagger
Admin

Posts : 208
Join date : 2012-12-02

View user profile http://comictagger.forumotion.com

Back to top Go down

Re: Search stopped returning accurate results suddenly

Post  anomander on Fri Jan 31, 2014 3:27 am

Just to confirm all working here. Nice one.
avatar
anomander

Posts : 74
Join date : 2013-03-28

View user profile

Back to top Go down

Re: Search stopped returning accurate results suddenly

Post  Mock1 on Thu Feb 13, 2014 10:41 pm

I appreciate the update to ComicTagger, just like everyone else. Good to see it's not abandoned.

However, I am seeing weird behavior in the search logic after the API change.

Try searching these title in the app and be ready to scratch your head:
"Damian: Son of Batman"
"All-New X-Men"
"The Superior Foes of Spider-Man"
"X-treme X-men"
"Green Lantern Corps Annual"

Now take out any word in any of those titles (or two in the case of Spider-man), now they pull results.
It's like there is a limit to the number of core words in the search (sometimes, it doesn't seem to count "and", "the", "to"; but does count hyphenated words as two). But the limits seems to vary, sometimes 3, sometimes 4.
To confuse things, these do work;
"Nick Fury Agent of SHIELD"
"Guardians of the Galaxy"

Is there a string limit on the API search now?

Mock1

Posts : 1
Join date : 2014-02-13

View user profile

Back to top Go down

Re: Search stopped returning accurate results suddenly

Post  DP812 on Fri Feb 14, 2014 7:01 am

I can second the problem with All-New X-Men, also having trouble with All-New X-Factor and Thor: God of Thunder. I have to remove the "All-New" from the X-books and "God of Thunder" from Thor to even have the titles show up in search results, otherwise I get "no matches found."

DP812

Posts : 74
Join date : 2012-12-08

View user profile

Back to top Go down

Re: Search stopped returning accurate results suddenly

Post  ComicTagger on Fri Feb 14, 2014 9:17 pm

Looks like the results from the ComicVine API are in flux. Ugh.

It looks like the previous way of I was doing the search queries is working again now, and the new technique is sorta broken. I want to see what what happens, but if things seems stable will do a new build next week.
avatar
ComicTagger
Admin

Posts : 208
Join date : 2012-12-02

View user profile http://comictagger.forumotion.com

Back to top Go down

Missing Series

Post  Dereck50 on Thu Feb 20, 2014 3:37 pm

10 Series are no longer showing up in the database when I try to Auto-Tag them.

For example, I tried to Auto-Tag "Batman and Robin v2 #28 (2014)".
No results came up so I clicked on Auto-Identify and nothing came up there either.
I changed the name of the series to Batman, saved the tags, then clicked on Auto-Identify and the Batman and Robin series (with the 27 previous issues) did not appear in the list.

I've used ComicTagger to update the 27 previous issues so I know it used to be there.

I'm using ComicTagger version 1.1.10-beta so I uninstalled it, and reinstalled version 1.1.9-beta, but the same problem persists.

I uninstalled 1.1.9-beta and reinstalled the current version.

Here are the other 9 series that I'm having the same problems with:

Green Lantern - New Guardians v1 #28 (2014)
Harley Quinn v1 #03 (2014)
Iron Man Annual v5 #01 (2014)
Justice League v2 #28 (2014)
Marvel Knights Hulk v1 #03 (2014)
Trinity of Sin - Pandora v1 #08 (2014)
Uncanny X-Men v3 #17 (2014)
Wonder Woman v4 #28 (2014)
X-Men v4 #11 (2014)


Dereck50

Posts : 7
Join date : 2014-02-20
Location : New York

View user profile

Back to top Go down

Re: Search stopped returning accurate results suddenly

Post  ComicTagger on Thu Feb 20, 2014 4:12 pm

It seems that Comic Vine has been doing a lot of back-end changes to their database, and the flaky results you're seeing are a result of that. I've posted on the API developer's forum, but no feedback from them on when or if things will be fixed.

If I had a even a short-term solution, I would create a new release of ComicTagger, but unfortunately, we're stuck with what we're getting for now. Sorry Sad
avatar
ComicTagger
Admin

Posts : 208
Join date : 2012-12-02

View user profile http://comictagger.forumotion.com

Back to top Go down

Re: Search stopped returning accurate results suddenly

Post  Dereck50 on Thu Feb 20, 2014 4:52 pm

ComicTagger wrote:It seems that Comic Vine has been doing a lot of back-end changes to their database, and the flaky results you're seeing are a result of that.  I've posted on the API developer's forum, but no feedback from them on when or if things will be fixed.

If I had a even a short-term solution, I would create a new release of ComicTagger, but unfortunately, we're stuck with what we're getting for now. Sorry Sad

No problem, just wanted to keep you up to date on the issues (if you didn't know already).

Dereck50

Posts : 7
Join date : 2014-02-20
Location : New York

View user profile

Back to top Go down

Re: Search stopped returning accurate results suddenly

Post  jaytdub on Fri Feb 21, 2014 2:25 pm

I am having the same issue with several of the series mentioned. While this is being worked on I found a few workarounds as mentioned above by removing certain words and using the "Search Online" option. Here are the series I was having trouble with:

Wonder Woman - Change to "Woman"
X-Men - Change to "Men"
Amazing X-Men - change to "Amazing"
Uncanny X-Men - Change to "Uncanny"
Justice League - Change to "Justice"
Iron Man Annual - Change to "Annual" (This one takes a bit to search)
Harley Quinn - Change to "Quinn"
Green Lantern New Guardians - Change to "Guardians"

Sadly if you want to tag for both CBL and CR, you'll have to do all of this twice.


jaytdub

Posts : 1
Join date : 2014-02-21

View user profile

Back to top Go down

Re: Search stopped returning accurate results suddenly

Post  Dereck50 on Fri Feb 21, 2014 3:26 pm

Thanks for the tip!

Hopefully the ComicVine database people will respond soon to ComicTagger's query so that he can update his software accordingly.

Dereck50

Posts : 7
Join date : 2014-02-20
Location : New York

View user profile

Back to top Go down

Re: Search stopped returning accurate results suddenly

Post  DP812 on Fri Feb 21, 2014 5:01 pm

jaytdub wrote:I am having the same issue with several of the series mentioned.  While this is being worked on I found a few workarounds as mentioned above by removing certain words and using the "Search Online" option.  Here are the series I was having trouble with:

Wonder Woman - Change to "Woman"
X-Men - Change to "Men"
Amazing X-Men - change to "Amazing"
Uncanny X-Men - Change to "Uncanny"
Justice League - Change to "Justice"
Iron Man Annual - Change to "Annual" (This one takes a bit to search)
Harley Quinn - Change to "Quinn"
Green Lantern New Guardians - Change to "Guardians"

Sadly if you want to tag for both CBL and CR, you'll have to do all of this twice.

Thanks, this has been an immense help. ComicVine has made a huge mess of things. Another addition: for Avengers World, change it to World.

DP812

Posts : 74
Join date : 2012-12-08

View user profile

Back to top Go down

Re: Search stopped returning accurate results suddenly

Post  Sponsored content


Sponsored content


Back to top Go down

View previous topic View next topic Back to top

- Similar topics

 
Permissions in this forum:
You cannot reply to topics in this forum